cleanup legacy Querier iterators code (take 1) #5825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
commented
Mar 21, 2024
| for set.Next() { | ||
| s := set.At() | ||
|
|
||
| if sc, ok := s.(SeriesWithChunks); ok { |
There was a problem hiding this comment.
I think we use SeriesWithChunks only in streamingSelect when querying Ingesters and the merge already happened there.
I am a little bit unsure why we need to get those chunks again and partition them again into a series set using partitionChunks. Isn't it already a series set from the input? We already only get 1 input series set with chunks since we only have 1 distributor querier.
3 tasks
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
cleanup-iterators
branch
from
ea4e717 to
fcf3338
Compare
|
@alanprot Can you please take a look? |
Signed-off-by: Ben Ye <benye@amazon.com>
|
I think this LGTM. |
alanprot
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Take 1 to clean up some legacy code/iterators in Querier. I believe those are code used with the old chunk storage and it is time to clean them up and reuse the Prometheus storage interface as much as possible.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]