Skip to content

Conversation

@harry671003
Copy link
Contributor

What this PR does:

  • Fixes flakiness in fuzz tests for count_values func.
  • count_values returns a float in the metric which is not always accurate.
[
  {
    "metric": { "job": "prometheus", "value": "0" },
    "value": [1734628158, "5"]
  },
  {
    "metric": { "job": "prometheus", "value": "16254.5" },
    "value": [1734628158, "9"]
  },
  {
    "metric": { "job": "prometheus", "value": "17551.083333333336" },
    "value": [1734628158, "1"]
  }
]

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeya24 yeya24 merged commit c685cf4 into cortexproject:master Jan 3, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants