-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule information to query paramters sent to the QFE #6539
base: master
Are you sure you want to change the base?
Add rule information to query paramters sent to the QFE #6539
Conversation
Maybe we can return the stats at least on the proto response? |
@alanprot |
8ea9f15
to
cdda1c8
Compare
But the rulers logs would still be "empty" right? so should we at least stop logging it? |
Yeah, the evaluation logs are still empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Stopping the logging at the Ruler is fine for me.
Do we want to do this? Or it is already doable by just turning off query stats log in Ruler
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
cdda1c8
to
dee8817
Compare
@yeya24 |
When the
-ruler.frontend-address
is configured, the Ruler evaluates rules via QFE. But, all of the values of the query stats logs and metrics in the Ruler are0
because the QFE doesn't send query stat.In Ruler, for example:
the query stats logs are:
Also, the values of these metrics are all
0
To address it, this PR adds rule information to query parameters sent to the QFE to leave rule information logs on query stats.
For the metric, #6470 add the
source
label to categorize query stat metric.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]