Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TransferChunks gRPC method #6543

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Remove TransferChunks gRPC method #6543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/cortex/cortex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,13 +344,10 @@ func New(cfg Config) (*Cortex, error) {
tenant.WithDefaultResolver(tenant.NewMultiResolver())
}

// Don't check auth header on TransferChunks, as we weren't originally
// sending it and this could cause transfers to fail on update.
cfg.API.HTTPAuthMiddleware = fakeauth.SetupAuthMiddleware(&cfg.Server, cfg.AuthEnabled,
// Also don't check auth for these gRPC methods, since single call is used for multiple users (or no user like health check).
[]string{
"/grpc.health.v1.Health/Check",
"/cortex.Ingester/TransferChunks",
"/frontend.Frontend/Process",
"/frontend.Frontend/NotifyClientShutdown",
"/schedulerpb.SchedulerForFrontend/FrontendLoop",
Expand Down
Loading