Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit more histogram buckets for cortex-querier_storegateway_refetches… #6570

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Emit more histogram buckets for cortex-querier_storegateway_refetches… #6570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## master / unreleased

* [FEATURE] Querier/Ruler: Add `query_partial_data` and `rules_partial_data` limits to allow queries/rules to be evaluated with data from a single zone, if other zones are not available. #6526
* [ENHANCEMENT] StoreGateway: Emit more histogram buckets on the `cortex_querier_storegateway_refetches_per_query` metric. #6570
* [ENHANCEMENT] Querier: Apply bytes limiter to LabelNames and LabelValuesForLabelNames. #6568
* [ENHANCEMENT] Query Frontend: Add a `too_many_tenants` reason label value to `cortex_rejected_queries_total` metric to track the rejected query count due to the # of tenant limits. #6569
* [BUGFIX] Ingester: Avoid error or early throttling when READONLY ingesters are present in the ring #6517
Expand Down
2 changes: 1 addition & 1 deletion pkg/querier/blocks_store_queryable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func newBlocksStoreQueryableMetrics(reg prometheus.Registerer) *blocksStoreQuery
Namespace: "cortex",
Name: "querier_storegateway_refetches_per_query",
Help: "Number of re-fetches attempted while querying store-gateway instances due to missing blocks.",
Buckets: []float64{0, 1, 2},
Buckets: []float64{0, 1, 2, 4, 8},
}),
}
}
Expand Down
8 changes: 8 additions & 0 deletions pkg/querier/blocks_store_queryable_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,8 @@ func TestBlocksStoreQuerier_Select(t *testing.T) {
cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1
cortex_querier_storegateway_refetches_per_query_sum 0
cortex_querier_storegateway_refetches_per_query_count 1
Expand Down Expand Up @@ -913,6 +915,8 @@ func TestBlocksStoreQuerier_Select(t *testing.T) {
cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 0
cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 0
cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1
cortex_querier_storegateway_refetches_per_query_sum 2
cortex_querier_storegateway_refetches_per_query_count 1
Expand Down Expand Up @@ -1850,6 +1854,8 @@ func TestBlocksStoreQuerier_Labels(t *testing.T) {
cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1
cortex_querier_storegateway_refetches_per_query_sum 0
cortex_querier_storegateway_refetches_per_query_count 1
Expand Down Expand Up @@ -2078,6 +2084,8 @@ func TestBlocksStoreQuerier_Labels(t *testing.T) {
cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 0
cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 0
cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1
cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1
cortex_querier_storegateway_refetches_per_query_sum 2
cortex_querier_storegateway_refetches_per_query_count 1
Expand Down
Loading