Skip to content

Implementing Parquet Converter #6716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 29, 2025

Conversation

alanprot
Copy link
Member

@alanprot alanprot commented Apr 22, 2025

What this PR does:

Implementing parquet converter:

The documentation of this component is hidden for now as the feature is not code complete (We need to create the parquet queriable).

Which issue(s) this PR fixes:
Partially Fixes #6712

Checklist

  • Tests updated
  • [NA] Documentation added
  • [NA for now] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@alanprot alanprot changed the title Inital Commit - Skeleton Implementing Parquet Converter Apr 22, 2025
@alanprot alanprot force-pushed the parquet-converter branch from b0c7c06 to 2eec8b9 Compare April 22, 2025 18:12
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot force-pushed the parquet-converter branch 3 times, most recently from 57efb1c to 5e75bc8 Compare April 22, 2025 20:04
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot force-pushed the parquet-converter branch from 5e75bc8 to d820fd5 Compare April 22, 2025 22:22
Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot force-pushed the parquet-converter branch 2 times, most recently from 01a64a4 to 2497df1 Compare April 25, 2025 00:53
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot force-pushed the parquet-converter branch from 2497df1 to 46e3114 Compare April 25, 2025 00:56
@alanprot alanprot marked this pull request as ready for review April 25, 2025 00:58
@dosubot dosubot bot added go Pull requests that update Go code sync-vendor labels Apr 25, 2025
@alanprot alanprot force-pushed the parquet-converter branch 4 times, most recently from 3d72c44 to cc6d121 Compare April 25, 2025 01:10
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot force-pushed the parquet-converter branch from cc6d121 to 4fa4df6 Compare April 25, 2025 01:50
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot force-pushed the parquet-converter branch from fa8300a to 1c8eda0 Compare April 25, 2025 02:35
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a changelog for this feature? Even though it is a hidden feature now still worth a changelog

Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot force-pushed the parquet-converter branch from 2e731ce to ee0e73d Compare April 28, 2025 22:06
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot force-pushed the parquet-converter branch from ee0e73d to f72e3d3 Compare April 28, 2025 22:07
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot
Copy link
Member Author

Let's add a changelog for this feature? Even though it is a hidden feature now still worth a changelog

Done!

Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot force-pushed the parquet-converter branch from 3a61b85 to db9de10 Compare April 28, 2025 23:06
Signed-off-by: Alan Protasio <approtas@amazon.com>
@alanprot alanprot merged commit 9f70dd9 into cortexproject:master Apr 29, 2025
17 checks passed
@alanprot alanprot deleted the parquet-converter branch April 29, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code size/XL sync-vendor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants