Skip to content

Added name validation scheme as a config field and flag as well #6733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

av153k
Copy link

@av153k av153k commented May 8, 2025

What this PR does:

  • Adds name_validation_scheme as yaml flag and name.validation.scheme as a flag
  • Remove config init and set the model.NameValidationScheme directly in New() method to creating a Cortex object

Which issue(s) this PR fixes:
Fixes #6702

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Abhishek Anand <lex.abhishek@gmail.com>
@av153k av153k force-pushed the feat/namevalidationscheme-flag branch from 2186312 to 146188f Compare May 8, 2025 07:00
@av153k av153k marked this pull request as ready for review May 8, 2025 09:54
@av153k
Copy link
Author

av153k commented May 8, 2025

I am working on the tests for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make NameValidationScheme configurable
1 participant