Skip to content

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Aug 12, 2025

What this PR does:

There is a bug discovered in grpc-go v1.72.x release where active streams are not cleaned up properly and caused gRPC stream to be refused. Thanks @alanprot for discovering the bug and creating the reproduce test grpc/grpc-go#8504.

To prevent impact to Cortex users when releasing this change, downgrade gRPC version to v1.71.2.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added go Pull requests that update Go code type/bug labels Aug 12, 2025
Signed-off-by: yeya24 <benye@amazon.com>
@yeya24 yeya24 force-pushed the downgrade-gRPC-version branch from 2fb44d8 to 37cba03 Compare August 12, 2025 21:06
Signed-off-by: yeya24 <benye@amazon.com>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 12, 2025
Signed-off-by: yeya24 <benye@amazon.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2025
@yeya24 yeya24 merged commit ea792b1 into cortexproject:master Aug 13, 2025
32 of 34 checks passed
@yeya24 yeya24 deleted the downgrade-gRPC-version branch August 13, 2025 04:27
aclaygray pushed a commit to aclaygray/cortex that referenced this pull request Aug 18, 2025
Signed-off-by: Andrew Gray <agray@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code lgtm This PR has been approved by a maintainer size/M type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants