Add-changelog-for-utf8-support #7056
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Add-changelog-for-utf8-support
branch
from
c9503b1 to
7339ddb
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Add-changelog-for-utf8-support
branch
from
7339ddb to
055e6ee
Compare
| require.Equal(t, 200, res.StatusCode) | ||
| require.Equal(t, model.ValVector, queryResult.Type()) | ||
| vec := queryResult.(model.Vector) | ||
| require.Equal(t, 1, len(vec)) |
There was a problem hiding this comment.
We should try to cover label names and label values API as well. But we can do it in next PR
There was a problem hiding this comment.
Should we remove https://github.com/cortexproject/cortex/blob/master/pkg/cortex/configinit/init.go as we start accepting UTF-8?
I've noticed the labelValues api with UTF-8 label name fails since we currently set the legacy scheme as default.
There was a problem hiding this comment.
We should. I think we might be missing some test cases so we didn't find this in previous PR. Any components that do label/metric validation needs to accept the validation scheme otherwise you modify the global validation scheme variable
There was a problem hiding this comment.
I removed it and added label names/values e2e test case.
There was a problem hiding this comment.
I think we are missing more test cases like alertmanager and even ruler configurations with UTF 8 labels.
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Add-changelog-for-utf8-support
branch
from
21d3334 to
3a1c61e
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
3 participants
Add a change log for #7040 and a test case for UTF8 querying
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]