Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update only on successful connections #21

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

cortze
Copy link
Owner

@cortze cortze commented Aug 14, 2023

Motivation

The lookup operation was taking into account connection failures as a reason to increase the stepsCnt because it doesn't indeed provide any closer nodes.

Related links:

Description

This PR fixes that wrong behavior of the lookup function

Tasks

  • set or reset the stepsCnt only with successful connections
  • add a new test case to check the accuracy of the DHT lookup with a given error rate

Proof of Success

  • test pass :)))))

@cortze cortze merged commit 778a355 into main Aug 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant