Revert build failure workaround #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build started failing due to changes in the Azure Build agent, as reported at actions/runner-images#7467 It appears that the underlying problem is a bug in the Node library being used to extract files from packages: ZJONSSON/node-unzipper#271 The problem was that this corrupted some of the files being unpacked. This meant that when we tried to run `func` we got errors complaining about an invalid executable. Although it looks like the underlying issue has not yet been fixed, the comment at actions/runner-images#7467 (comment) suggests that a new build agent image has been created that will not run into this problem. (Presumably they've done something to avoid the problematic package.) This means we should no longer need our workaround.
mwadams
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build started failing due to changes in the Azure Build agent, as reported at actions/runner-images#7467
It appears that the underlying problem is a bug in the Node library being used to extract files from packages: ZJONSSON/node-unzipper#271
The problem was that this corrupted some of the files being unpacked. This meant that when we tried to run
funcwe got errors complaining about an invalid executable.Although it looks like the underlying issue has not yet been fixed, the comment at actions/runner-images#7467 (comment) suggests that a new build agent image has been created that will not run into this problem. (Presumably they've done something to avoid the problematic package.) This means we should no longer need our workaround.