Images don't show as background-image when using css-loader sourceMap option

[drawveloper]

Reported here: webpack-contrib/css-loader#216
Discussed here: webpack-contrib/style-loader#55

I simply removed sourceMap from my build. I think it's worth it at least documenting this big caveat, but I'd vote to remove CSS sourceMap completely.

[coryhouse]

I see multiple options:

1. Disable css sourcemap
2. Disable css minification so we don't need the sourcemap
3. Advise using absolute paths for images
4. Leave as is and wait for a fix - though appears unclear if one is in the works

I lean toward option 2. Option 1 means debugging CSS would be difficult. Thoughts?

[drawveloper]

Minifying only in production build sounds good. (Without sourcemaps)

On Mon, Mar 21, 2016 at 12:43 PM Cory House notifications@github.com
wrote:

I see multiple options:

1. Disable css sourcemap
2. Disable css minification so we don't need the sourcemap
3. Advise using absolute paths for images
4. Leave as is and wait for a fix - though appears unclear if one is
   in the works

I lean toward option 2. Option 1 means debugging CSS would be difficult.
Thoughts?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#81 (comment)

[coryhouse]

Just occurred to me - the reason sourcemaps are so useful is we're compiling from SASS. So without them, you're lost during dev. Now I'm torn. We basically have a choice between:

1. Disable sourcemaps, which provides a bad CSS debugging experience for all
2. Keep sourcemaps, and let those with this issue use absolute paths or wait for a fix.

After thinking about this more, I think keeping sourcemaps on is the best approach. We'd certainly want them if it weren't for this (hopefully short-term) bug.

[drawveloper]

I'd just like to add that "those with this issue" should be 100% of people
working on a real world app. How can you not use background-image? :)

At least we should have a FAQ in the README, I guess.

On Mon, Mar 21, 2016 at 1:57 PM Cory House notifications@github.com wrote:

Just occurred to me - the reason sourcemaps are so useful is we're
compiling from SASS. So without them, you're lost during dev. Now I'm torn.
We basically have a choice between:

1. Disable sourcemaps, which provides a bad CSS debugging experience
   for all
2. Keep sourcemaps, and let those with this issue use absolute paths
   or wait for a fix.

After thinking about this more, I think keeping sourcemaps on is the best
approach. We'd certainly want them if it weren't for this (hopefully
short-term) bug.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#81 (comment)

[lovio]

Just disable css sourceMaps and it works

[zsherman]

I'd also vote for option #2 fwiw.

[Strate]

This is a fix webpack-contrib/style-loader#96

[coryhouse]

@Strate Great to hear! Hopefully they accept that PR soon.

[kwelch]

PR #207 uses the fix quick fix discussed in webpack-contrib/style-loader#96, so this item should be resolved. I can re-test to verify.

[kwelch]

Validated with the update to set webpack path dynamically, relative background images work.

Closing.

[coryhouse]

Awesome! Thanks Kyle!