webpack-hot-middleware/client reload params configured to true #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great call! Didn't even know this option existed. My only hesitation is some people will be confused by how sometimes a full reload occurs. I believe the rule is top-level components will always require a reload. Are there other instances this would occur? Regardless, I agree this is a win, so merging. Thanks for the PR! |
|
I didn't find description about reload conditions. Documentation doesn't say something concrete. It says that reload happens when webpack stucks. Also this option was mention in breaking changes on version 2.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it will be better DX to have full reload when webpack gets stuck.config
This very useful for case when HMR fails due to stateless functional components. It's easy to reproduce for top level components like
ApporAboutPage