Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerDependencies ^ problem fix #53

Merged
merged 1 commit into from
Jun 17, 2015
Merged

Conversation

pgmemk
Copy link
Contributor

@pgmemk pgmemk commented Jun 17, 2015

Thank you very much for this module. I am using it for our company's app.

Here is a minor problem:

When running 'npm install' I got the error message

npm ERR! peerinvalid Peer react-native-addressbook@0.1.1 wants react-native@^0.5.0

After some googling :-) I found this discussion special-case for 0.x in ^ is very counter-inutitive and rage-inducing #79

I changed the versioning to reflect your intended use of the caret

corymsmith added a commit that referenced this pull request Jun 17, 2015
peerDependencies ^ problem fix
@corymsmith corymsmith merged commit c5a0274 into corymsmith:master Jun 17, 2015
@corymsmith
Copy link
Owner

@pgmemk Thanks for the PR!

@corymsmith
Copy link
Owner

Just merged and published to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants