Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart watcher when server is gone #226

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Restart watcher when server is gone #226

merged 5 commits into from
Feb 16, 2023

Conversation

mruoss
Copy link
Collaborator

@mruoss mruoss commented Feb 16, 2023

  • Adds a heartbeat to the HTTPAdapter to stop processes for closed connections
  • Removes HTTPAdapters from Registry when the connection is closed for writing
  • Retries to start the watcher after the server has gone away
  • Adds a bunch of log statements and a macro to prefix them with the module name

Fixes #222


Requirements for all pull requests

  • Entry in CHANGELOG.md was created

@mruoss mruoss marked this pull request as draft February 16, 2023 19:11
* Adds a heartbeat to the HTTPAdapter to stop processes for closed connections
* Removes HTTPAdapters from Registry when the connection is closed for writing
* Retries to start the watcher after the server has gone away
@mruoss mruoss marked this pull request as ready for review February 16, 2023 19:43
@mruoss mruoss merged commit 9197f1f into develop Feb 16, 2023
@mruoss mruoss deleted the handle-server-gone branch February 16, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does the watch steam handle disconnects in V2?
1 participant