fix: allow http body types in the Base runner return #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - This should fix coryodaniel#352 - Allow binary as a return value from the base runner, because sub resource types will have non-resource results. Eg. Logs from `pods/log` are binary in whatever enconding the log decided to spit out. It can't be parsed as json since it might not even be utf-8 Test Plan: - `mix binary`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add existing
body_ttoreturn_tfor Client.Runner.Base. This allows the base runner to return binary data. This happens when asking for a subresource.Fixes: #352