Moving signatureAlgorithm placement #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing the change proposed in #149
"signature" and "signatureAlgorithm"
|
Need to update examples...! |
emanjon
approved these changes
Mar 26, 2024
|
@highlunder Need to update the signature in the native certificate example |
|
Ja jag såg just att du uppdaterade cert-innehållet utan att uppdatera signaturen. Jag kan gräva fram min gamla kod, men lovar inte att det går supersnabbt. Om du/vi inte vill ha ett par dagars bristande överensstämmelse så behöver du byta tillbaka så länge. //J
…________________________________
Från: John Preuß Mattsson ***@***.***>
Skickat: den 26 mars 2024 14:10
Till: cose-wg/CBOR-certificates ***@***.***>
Kopia: Joel Höglund ***@***.***>; Mention ***@***.***>
Ämne: Re: [cose-wg/CBOR-certificates] Moving signatureAlgorithm placement (PR #153)
@highlunder<https://github.com/highlunder> Need to update the signature in the native certificate example
h'6FC903015259A38C0800A3D0B2969CA21977E8ED6EC344964D
4E1C6B37C8FB541274C3BB81B2F53073C5F101A5AC2A928865
83B6A2679B6E682D2A26945ED0B2'
58 40 6F C9 03 01 52 59 A3 8C 08 00 A3 D0 B2 96 9C A2 19 77 E8 ED 6E
C3 44 96 4D 4E 1C 6B 37 C8 FB 54 12 74 C3 BB 81 B2 F5 30 73 C5 F1 01
A5 AC 2A 92 88 65 83 B6 A2 67 9B 6E 68 2D 2A 26 94 5E D0 B2
—
Reply to this email directly, view it on GitHub<#153 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACA4D3MDIRR3V5XXJTONF7LY2FQSNAVCNFSM6AAAAABBYH7TFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRQGM4TCNZVGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I think we should not merge the PR before the PR is internally consistent, and that requires updating the native signatures. |
Actually moving the sign.alg field + new signature for the native c509 example cert
gselander
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the change proposed in #149