Editable task titles #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmstick
force-pushed
the
editable
branch
2 times, most recently
from
7c6c1a7 to
4bf0835
Compare
|
Everything looks good, only thing I noticed is that it is now significantly harder to open the task details now that we have an editable input, I'm thinking that maybe we should have a dedicated details button instead of making the list item clickable. We can merge this regardless, I'll make the changes later. |
|
Thanks Michael! 🎉 |
|
Perhaps an editable input should not capture an event unless it is in write mode |
|
I will push a fix to libcosmic |
|
The fix is here: pop-os/libcosmic#391 |
|
How do you feel about a double click to edit the input? |
|
Looking at the keyboard shortcuts page, the spec says to make the text editable and focused on a single click, and select all text on a double click |
|
That sounds good as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes the new editable_input widget in libcosmic. Some further refinements will be necessary, but it's now possible to test the feature in practice here.