Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to content view #2

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

mmstick
Copy link
Contributor

@mmstick mmstick commented Mar 15, 2024

  • Make the list view scrollable
  • Place list items into a list column
  • Improve styling of list item buttons
  • Minor refactoring

@mmstick
Copy link
Contributor Author

mmstick commented Mar 15, 2024

There are some oddities I found that will require adjustments inside libcosmic.

@edfloreshz edfloreshz merged commit 23c81f6 into cosmic-utils:main Mar 15, 2024
@edfloreshz
Copy link
Member

Thanks! 🎉

What specifically needs adjustment?

@mmstick
Copy link
Contributor Author

mmstick commented Mar 15, 2024

I definitely need to finish the list view widget and its button styles. The list column is adding some extra padding on the top and bottom that shouldn't be there, or at lest be configurable. The icon button is no longer as round as it used to be. There's also some layer container component theme issues.

@mmstick mmstick deleted the contents branch March 15, 2024 17:45
@mmstick
Copy link
Contributor Author

mmstick commented Mar 15, 2024

Should empty lists also show the header?

@edfloreshz
Copy link
Member

To maintain consistency between lists I think they should.

@edfloreshz
Copy link
Member

Implemented in #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants