Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix README.md typo #30

Merged
merged 5 commits into from
Aug 2, 2024
Merged

fix README.md typo #30

merged 5 commits into from
Aug 2, 2024

Conversation

hoangph271
Copy link
Contributor

No description provided.

@edfloreshz
Copy link
Member

Why is this is modifying Cargo.lock?

@hoangph271
Copy link
Contributor Author

@edfloreshz whoops, sorry

I created the PR and THEN pushed a new commit to my repo to update libcosmic to make double click to maximize works

but I pushed to the same branch and didn't realize the effect.

should I close this PR and create another one ?
or should I revert the commit ?

@edfloreshz
Copy link
Member

You can rebase interactive and delete the commit from this branch 👍🏼 if you find it easier you could also open a new PR.

@edfloreshz
Copy link
Member

On second thought, leave it as is, we probably need to update libcosmic anyway.

@edfloreshz edfloreshz merged commit dbcd2a9 into cosmic-utils:main Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants