forked from pantsbuild/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify python local dist handling code. (pantsbuild#5480)
Previously, BuildLocalPythonDistributions generated local dists and put them in products. Downstream tasks then synthesized PythonRequirementLibrary targets to point to the local dists, if they needed to resolve them. This was clunky, and required special knowledge of local dist issues to reside in multiple downstream tasks. This change has BuildLocalPythonDistributions itself inject the synthetic PythonRequirementLibrary targets - one per dist - and stitches them into the build graph. Downstream tasks no longer need to know or care about local dists (apart from declaring them as required products), they just see PythonRequirementLibrary targets, whether synthetic or organic, and handle them uniformly. Note that previously PythonBinaryCreate had to do some footwork to ensure that only the dists depended on by a specific PythonBinary were used when creating that binary. This now happens naturally, since we generate one requirement library per dist, and the dependencies are wired up in the right way.
- Loading branch information
Showing
6 changed files
with
56 additions
and
90 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters