Add impl std::error::Error for FluentError #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
reviewed
Feb 24, 2018
|
No problem and you are welcome. |
cosmo0920
approved these changes
Feb 25, 2018
There was a problem hiding this comment.
I've read this article and your test code.
This change is pretty reasonable. 👍
|
I'd published this change as 0.10.0. |
|
Sure thank you for accepting the PR! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @cosmo0920, currently I am using your
fruentlycrate, and thanks for your good work! 👍I am not sure if you are willing to accept PR, but I would like to add some features as listed below, and hopefully you don't mind.
Changes:
failurecrate easily.Let me know if you have any comments (e.g. bumping crate version) and thanks!