Skip to content

Conversation

alexdraconian
Copy link
Contributor

This will fix table aggregation links are stored in metadata. Originally lists and clouds were not rendered metadata, so I assume this line is accidentally excluded in tables.

P.S. It seems SQLite plugin ignores search filter in 'metadata' rendering mode. Because of it, documents with table aggregation may include unnesessary relation data in their metadata. So it's correct that #467 is problem, not intended function.

P.S.2. This code will not 'clear' metadata automatically. Admins must use another plugin for rebuilding metadata if they want to.

Fix metadata rendering for aggregation.
@alexdraconian
Copy link
Contributor Author

Ok, I found real cause of this problem.

When rendering metadata, global $INFO is null. So filter placeholders like $ID$, $PAGE$ cannot be resolved properly(resolved as empty string); This results every pages are returned from SQL query, no matter how filter is set.

So I made changes:

  • If $INFO is null, get page information with dokuwiki global function pageinfo().
  • Re-enabled metadata rendering for table, list, cloud aggregations.

Enables metadata rendering for page data, especially for internal links.
@alexdraconian
Copy link
Contributor Author

I'm closing this pull request since there're still some awakwardness in my code. I will re-open in other pull request when I get time to make fix for it.

@alexdraconian
Copy link
Contributor Author

Replaced with #609.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant