Skip to content

Conversation

alexdraconian
Copy link
Contributor

@alexdraconian alexdraconian commented Aug 8, 2023

Replacement of #609, after filter refactoring.

Fix various issues with metadata render.

Current code has following problems, with metadata rendering.

List and cloud internal links are not be rendered to metadata.
Table filters ARE NOT be correctly applied to metadata rendering. This means, EVERY pages will be added as internal link to metadata, regardless of table filter options. As a result, backlinks of page will contain non-related pages.
Dynamic filters and limit parameter ARE applied to metadata rendering. This means every time dynamic filter is applied or user visit another page of table, backlinks will also be changed dynamically. This will delete related pages from backlink.
This pull request resolves above problems with following solution:

Enable list and cloud metadata rendering
In metadata rendering, dynamic filters and limit parameter will be ignored. To achieve this, I edited code so that syntax can be rendered twice; metadata and xhtml.
I tested this code with my personal wiki, which has 1,200 pages and a lot of struct aggregation. But if I missed something, please let me know.

@splitbrain
Copy link
Member

@alexdraconian currently all tests fail can you check what's up with that? Also could you add tests for the functionality you're changing here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants