Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update osmosis versions #911

Closed
wants to merge 2 commits into from
Closed

Conversation

niccoloraspa
Copy link

This PR:

  • fixes some inconsistencies in the osmosis versions:
    "name": "v5",        # wrong
    "name": "v6",        # correct
    "tag": "v6.4.1",
  • bumps all major version to the latest patch release
    "tag": "v10.0.1",  # wrong
    "tag": "v10.1.1"

@JeremyParish69
Copy link
Collaborator

JeremyParish69 commented Oct 24, 2022

Thanks @niccoloraspa .
Due to some automation, the entire codebase section here for Osmosis is automatically updated based on a file upstream: this schema file in the Osmosis repo. Changes should instead be made there, or else it will just be automatically overwritten back.
Regarding the bumping of major version to the latest patch release, I agree this is a good idea.
Regarding the correcting of names of version (e.g., v5 to v6), although I don't think it matter too much, I believe your suggestion may be incorrect. The name v5 for tag v6 wasn't a typo. I recall for a while the version names (which at one time took after the names of elements of the periodic table of elements) were definitely out of sync. For example, the Nitrogen (atomic number 7) had the upgrade tag of 'v8'.

@JeremyParish69 JeremyParish69 marked this pull request as draft October 24, 2022 22:50
@niccoloraspa
Copy link
Author

niccoloraspa commented Oct 26, 2022

Thanks Jeremy, I will update the schema in the Osmosis repo!

Regarding the correcting of names of version (e.g., v5 to v6), although I don't think it matter too much, I believe your suggestion may be incorrect. The name v5 for tag v6 wasn't a typo. I recall for a while the version names (which at one time took after the names of elements of the periodic table of elements) were definitely out of sync. For example, the Nitrogen (atomic number 7) had the upgrade tag of 'v8'.

I think the underlying issue is that some versions are forks due to bugs. For example, v6 is the correct working version of the v5 release

      {
        "name": "v5",
        "tag": "v6.4.1",
        "height": 2383300,
        "next_version_name": "v7"
      },

However, the pattern is not very consistent as the next version jumps to v7 ???

      {
        "name": "v7",                
        "tag": "v8.0.0",
        "height": 3401000,
        "next_version_name": "v9"
      },

I agree that it's not a big deal, however, it's very confusing to have versions and tags so misaligned and it could be a source of bugs in the future.

I propose two options to bring a little bit more consistency:

  1. name = major version of the tag field (as in this PR)
      {
        #"name": "v7",        NO
        "name": "v8",               
        "tag": "v8.0.0",
         ...
      },
  1. name = element:
      {
        #"name": "v7",             NO
        "name": "nitrogen"    
        "tag": "v8.0.0",
        "height": 3401000,
        "next_version_name": "v9"
      },

I'm happy either way

@JeremyParish69
Copy link
Collaborator

@niccoloraspa this is also discussed briefly here:
#521
I also recall having a names array for each, so we could have both element name and a 'v#' name, but that was deemed unnecessary. I struggle to recall why we opted over v# over the elemental name, but someone may have preferred it that way?? Either way, a change like you've suggested--using element names instead--should be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants