Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tendermint 0.34 client support #344

Closed
webmaster128 opened this issue Aug 5, 2020 · 6 comments · Fixed by #430
Closed

Add Tendermint 0.34 client support #344

webmaster128 opened this issue Aug 5, 2020 · 6 comments · Fixed by #430

Comments

@webmaster128
Copy link
Member

As of nightly-2020-08-05, Cosmos SDK is still on Tendermint 0.33 (see https://github.com/cosmos/cosmos-sdk/blob/392121e/go.mod#L40). Upgrading to Tendermint 0.34 is planned for the stargate release, but not yet done: cosmos/cosmos-sdk#6365.

We can prepare by creating a Tendermint 0.34 client once there is a release (check https://github.com/tendermint/tendermint/releases, https://hub.docker.com/r/tendermint/tendermint/tags/?page=1&name=v0.34)

@ethanfrey
Copy link
Contributor

This may not be necessary for this deliverable. Depends if it is merged into simapp before we deliver. No need to block on it here. We need this for light-client proofs, not the merkle proofs

@webmaster128
Copy link
Member Author

Good, thank you. Then we just stop upgrading simapp once cosmos/cosmos-sdk#6365 is done.

@webmaster128
Copy link
Member Author

Here is a pending PR with the majority of the Tendermint upgrade, which will probably break interfaces: cosmos/cosmos-sdk#6892 Once this is in, we either need an updated client or pause updating simapp.

@ethanfrey
Copy link
Contributor

Good to follow that

@webmaster128
Copy link
Member Author

Simapp is based on Tendermint 0.34 starting with nightly-2020-08-15. Once we get Tendermint 0.34 RC docker images (tendermint/tendermint#5266) we can start working on a client.

@ethanfrey
Copy link
Contributor

Nice one 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants