Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tendermint 0.34 support #430

Merged
merged 8 commits into from
Sep 30, 2020
Merged

Add Tendermint 0.34 support #430

merged 8 commits into from
Sep 30, 2020

Conversation

webmaster128
Copy link
Member

Closes #344

Copy link
Contributor

@willclarktech willclarktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

readonly appCreator: string;
/** Values we expect in the backend */
readonly expected: ExpectedValues;
/** A workaround for https://github.com/tendermint/tendermint/issues/4489 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately the clock issue is relsolved now

@webmaster128
Copy link
Member Author

webmaster128 commented Sep 23, 2020

Tendermint 0.34 is not starting (or dying immediately before writing log entries) in the CI for some strange reason. Will investigate.

which does not work with multiple instances.
Instead debug start logs.
@webmaster128 webmaster128 added the automerge See mergify.io label Sep 30, 2020
@mergify mergify bot merged commit 11d712f into master Sep 30, 2020
@mergify mergify bot deleted the tm34 branch September 30, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge See mergify.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tendermint 0.34 client support
2 participants