Implement liveTx and min/max height search filters #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
search-min-max-height
branch
from
aab3d1e
to
1f0b684
Compare
ethanfrey
approved these changes
Feb 18, 2020
| txs = await this.cosmWasmClient.searchTx({ sentFromOrTo: sentFromOrTo }); | ||
| } else { | ||
| throw new Error("Unsupported query"); | ||
| } | ||
|
|
||
| return txs.map(tx => this.parseAndPopulateTxResponseUnsigned(tx)); | ||
| const filtered = txs.filter(tx => { |
There was a problem hiding this comment.
Oof, filtering client side. "Fake it til you make it".
But yeah, I agree you can fulfill the API properly now, while not being blocked on the "proper" backend changes.
There was a problem hiding this comment.
Exactly. But feel free to bring in CosmWasm/wasmd#73
| throw new Error("Query by minHeight/maxHeight not supported together with ID"); | ||
| } | ||
|
|
||
| // concat never() because we want non-completing streams consistently |
| * | ||
| * @see https://cosmos.network/rpc/#/Transactions/post_txs | ||
| */ | ||
| export enum BroadcastMode { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.