Skip to content

simplify eslint flat config #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

simplify eslint flat config #1786

wants to merge 6 commits into from

Conversation

dynst
Copy link
Contributor

@dynst dynst commented Aug 7, 2025 •
edited
Loading

And enable import lints on JS files again, not just TS files.

Also silence a lint by using a deep import from the CommonJS package semver. npm/node-semver#712 (comment)

dynst added 3 commits August 7, 2025 14:12
@dynst
simplify typescript flat config
b4c8eec
@dynst
simplify import plugin flat config
b0f0ac3 
And enable the recommended lints in JS files again.

Unclear why the lint triggers on this one import, though.
@dynst
use eslint-plugin-import's typescript resolver in all files
d8cc2ef 
it's what allows understanding the exports field.
@dynst dynst force-pushed the eslint-flat-simplify branch from 282b8dc to 2889863 Compare August 7, 2025 18:59
dynst added 2 commits August 7, 2025 19:16
@dynst
re-enable import/no-cycle
22a8b30 
no idea why but it stopped complaining once the conversion
to flat config was finished. something about import plugin
got reconfigured.
@dynst
silence import/no-named-as-default and save some bundle size
12a138d 
only a single function from this non tree shakeable
CJS dependency was needed.
@dynst dynst force-pushed the eslint-flat-simplify branch from 2889863 to 12a138d Compare August 7, 2025 19:16
webmaster128
webmaster128 reviewed Aug 13, 2025
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove @typescript-eslint/parser and @eslint/compat imports here, we can remove the dependencies from package.json too right?

@dynst
Copy link
Contributor Author

dynst commented Aug 13, 2025 •
edited
Loading

If we remove @typescript-eslint/parser and @eslint/compat imports here, we can remove the dependencies from package.json too right?

@eslint/compat can be safely removed, but parser has to stay, it's a peer dependency of the plugin. Pretty sure it gets referenced in every element of the array typescriptEslint.configs["flat/strict-type-checked"] (which is why it doesn't need to be specified again explicitly).

Error: @typescript-eslint/eslint-plugin tried to access @typescript-eslint/parser (a peer dependency) but it isn't provided by your application; this makes the require call ambiguous and unsound.

@webmaster128 webmaster128 added this to the 0.37 milestone Aug 14, 2025
@dynst dynst mentioned this pull request Oct 3, 2025
Closed
@webmaster128
Copy link
Member

Sorry for the delay. I think this is good to get merged once the conflicts are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.37
Development

Successfully merging this pull request may close these issues.
2 participants
@dynst @webmaster128