replace jasmine with vitest #1803
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynst
force-pushed
the
vitest-it
branch
4 times, most recently
from
886315e to
25f8e03
Compare
zero boilerplate files copied into every package directory.
versions before 0.3.7 had no TypeScript declarations for .mjs code.
|
Why is there a cosmjs/.github/workflows/test.yml Line 103 in 8fb7421 Line 154 in 31db121 Is there another way to do whatever it is it's doing? |
In a local test it took 9.8s to complete.
Even given the comment, 1s might be excessively large.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless Jasmine, Vitest doesn't need identical boilerplate files copied into every package directory.
Blocked on:
#1809
Converting is easy now that
xitis in use:xit=it.skipjasmine.stringMatching=expect.stringMatchingexpect(a).withContext(b)=expect(a, b)expectAsync(p).toBeRejectedWithError(/regex/)=expect(p).rejects.toThrowError(/regex/)