Pending tests follow up #1823
Pending tests follow up #1823
Conversation
webmaster128
force-pushed
the
pending-tests-follow-up
branch
from
e4d57fc to
8ad6506
Compare
| (tendermintEnabled ? describe : xdescribe)("With WebsocketClient", () => { | ||
| // don't print out WebSocket errors if marked pending | ||
| const onError = globalThis.process?.env.TENDERMINT_ENABLED ? console.error : () => 0; |
There was a problem hiding this comment.
Good news, this ternary-operator line (and similar lines in 3 other tests) can be deleted now that xdescribe() skips running this test code entirely, it can just use console.error directly.
| describe("Tendermint37Client", () => { | ||
| const { url, expected } = tendermintInstances[37]; | ||
|
|
||
| it("can connect to a given url", async () => { | ||
| pendingWithoutTendermint(); | ||
|
|
||
| (tendermintEnabled ? it : xit)("can connect to a given url", async () => { |
There was a problem hiding this comment.
This could all be simplified just to use xdescribe() for all these tests instead of modifying every test to use xit(), right?
There was a problem hiding this comment.
Yeah, we can probably move the check one level up.
I think all functionality that does not require a running backend should be pulled out of the Tendermint37Client into lower level code – in case something like that exists
|
|
||
| beforeAll(async () => { | ||
| if (tendermintEnabled()) { | ||
| if (tendermintEnabled) { |
There was a problem hiding this comment.
This is basically if (true) after this PR, so the if statement could be removed.
| }); | ||
|
|
||
| describe("connectionStatus", () => { | ||
| (enabled ? describe : xdescribe)("connectionStatus", () => { |
There was a problem hiding this comment.
Thanks for catching this. Not sure why the tests were even passing on #1809 if this test wasn't being skipped.
There was a problem hiding this comment.
They did not pass if no Tendermint backend is running. I got the failure locally. But in CI we always have Tendermint running.
Continuation of the work from #1809