Skip to content

tendermint-rpc: remove the last pending() call #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
+3 −12
Merged

tendermint-rpc: remove the last pending() call #1831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions packages/tendermint-rpc/src/rpcclients/http.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,7 @@ import { createJsonRpcRequest } from "../jsonrpc";
import { defaultInstance, tendermintEnabled } from "../testutil.spec";
import { http } from "./http";

function pendingWithoutHttpServer(): void {
if (globalThis.process?.env.HTTPSERVER_ENABLED) {
return;
}
pending("Set HTTPSERVER_ENABLED to enable HTTP tests");
}
const httpServerEnabled = !!globalThis.process?.env.HTTPSERVER_ENABLED;

const tendermintUrl = defaultInstance.url;
const echoUrl = "http://localhost:5555/echo_headers";
Expand All @@ -18,9 +13,7 @@ describe("http", () => {
expect(response).toEqual(jasmine.objectContaining({ jsonrpc: "2.0" }));
});

it("can POST to echo server", async () => {
pendingWithoutHttpServer();

(httpServerEnabled ? it : xit)("can POST to echo server", async () => {
const response = await http("POST", echoUrl, undefined, createJsonRpcRequest("health"));
expect(response).toEqual({
request_headers: jasmine.objectContaining({
Expand All @@ -36,9 +29,7 @@ describe("http", () => {
).toBeRejectedWithError(/(ECONNREFUSED|Failed to fetch|fetch failed|(request to .* failed))/i);
});

it("can POST to echo server with custom headers", async () => {
pendingWithoutHttpServer();

(httpServerEnabled ? it : xit)("can POST to echo server with custom headers", async () => {
// With custom headers
const response = await http(
"POST",
Expand Down
Loading