Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vesting support #54

Closed
wants to merge 8 commits into from

Conversation

msteiner96
Copy link
Member

Resolves #49

@vercel
Copy link

vercel bot commented Mar 30, 2022

@msteiner96 is attempting to deploy a commit to the Interchain Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 30, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

cosmos-multisig-ui – ./

🔍 Inspect: https://vercel.com/interchain/cosmos-multisig-ui/94eNfjKotmq8oPjW5osSXNw1NPgm
✅ Preview: https://cosmos-multisig-ui-git-fork-msteiner96-add-ve-831426-interchain.vercel.app

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

components/forms/TransactionSigning.js Show resolved Hide resolved
components/forms/TransactionSigning.js Show resolved Hide resolved
components/forms/VestingForm.js Outdated Show resolved Hide resolved
components/forms/VestingForm.js Outdated Show resolved Hide resolved
pages/multi/[address]/index.js Outdated Show resolved Hide resolved
pages/multi/[address]/index.js Outdated Show resolved Hide resolved
@webmaster128
Copy link
Member

@nooomski could you test this PR and check if it serves your needs for #49?

@nooomski
Copy link
Contributor

Tried this on a deployment on this preview build.
Got an error when signing: Error: Type URL does not exist in the Amino message type register.

@webmaster128
Copy link
Member

webmaster128 commented Mar 31, 2022

Hmm, the error message is not from latest CosmJS. Is the deployment URL the right one?

@msteiner96 did you rebase this on latest master?

@msteiner96
Copy link
Member Author

Oh no cosmjs needs to be updated for that. Need to merge master into it

@msteiner96
Copy link
Member Author

@nooomski It should work now, updated CosmJS in the branch

@nooomski
Copy link
Contributor

nooomski commented Apr 4, 2022

Tried it again using a most recent deployment: https://cosmos-multisig-22qjafq1m-interchain.vercel.app/
Was able to get the Keplr prompt, but signature failed:
Error creating signature: Error: Unregistered type url: /cosmos.vesting.v1beta1.MsgCreateVestingAccount

@nooomski
Copy link
Contributor

nooomski commented Apr 4, 2022

Btw, just wanted to add, the vesting end time should probably just be a regular date and time that the app converts to UNIX timestamp. Ideally some date picker would be implemented, but would be good for @samepant to look at the UX there.

@webmaster128
Copy link
Member

Error creating signature: Error: Unregistered type url: /cosmos.vesting.v1beta1.MsgCreateVestingAccount

The error message is coming from the Registry. The type is not added there. @msteiner96 can you add it here or in CosmJS? See defaultRegistryTypes in packages/stargate/src/signingstargateclient.ts.

@msteiner96
Copy link
Member Author

I've added it here. I'm currently trying to figure out why it worked in my latest test. I was able to sign it with keplr. Will investigate on this and tell you my results :)

@webmaster128
Copy link
Member

Did you? In the options you need custom Amino converters as well as a custom Registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for create-vesting-account
3 participants