Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosmos_proto): add annotation to denote version #133

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Conversation

julienrbrt
Copy link
Member

Replaces: #131

Note, if I add it in MessageOptions and FieldOptions, buf generate complains that it has already been defined.

Copy link
Member Author

@julienrbrt julienrbrt Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be pushing this to https://buf.build/cosmos/cosmos-proto once this PR is merged and tag a new cosmos-proto

@julienrbrt julienrbrt marked this pull request as ready for review February 16, 2024 13:19
@julienrbrt julienrbrt requested a review from a team as a code owner February 16, 2024 13:19
@julienrbrt
Copy link
Member Author

julienrbrt commented Feb 16, 2024

Closing this and reopening #131 as we decide that the increase in size is acceptable, given that source code info gives as well other information, such as doc and doesn't require us to refactor all our protos.

EDIT: After some time trying to fix #131 unsuccessfully, I am going back to this solution.

@julienrbrt julienrbrt closed this Feb 16, 2024
@julienrbrt julienrbrt deleted the julien/since branch February 16, 2024 13:35
@julienrbrt julienrbrt restored the julien/since branch April 9, 2024 10:30
@julienrbrt julienrbrt reopened this Apr 9, 2024
@aaronc
Copy link
Member

aaronc commented Apr 9, 2024

So we can't also add this to method options and field options? That should be possible somehow

@julienrbrt
Copy link
Member Author

So it seems like it gets inherited. If I add it at a lower level, it complains it is already defined.

@aaronc
Copy link
Member

aaronc commented Apr 12, 2024

So it seems like it gets inherited. If I add it at a lower level, it complains it is already defined.

Are there test examples? That doesn't seem consistent with my experience.

@julienrbrt
Copy link
Member Author

So it seems like it gets inherited. If I add it at a lower level, it complains it is already defined.

Are there test examples? That doesn't seem consistent with my experience.

image
image

@aaronc
Copy link
Member

aaronc commented Apr 12, 2024

But does it actually work at the field level?

@julienrbrt
Copy link
Member Author

julienrbrt commented Apr 12, 2024

But does it actually work at the field level?

Given the error message I expected it to. Adding a test.
EDIT: 3.proto:21:24:field CounterQueryResponse.counter: option (cosmos_proto.since): extension cosmos_proto.since should extend google.protobuf.FieldOptions but instead extends google.protobuf.ServiceOptions :(

@aaronc
Copy link
Member

aaronc commented Apr 12, 2024

Maybe we try something like field_added, service_added, etc?

@julienrbrt
Copy link
Member Author

julienrbrt commented Apr 17, 2024

little bump here :) I want to integrate it in client/v2 asap.

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot cleaner than comments, than kyou

@julienrbrt julienrbrt requested a review from aaronc April 17, 2024 12:54
@aaronc
Copy link
Member

aaronc commented Apr 17, 2024

Method added since, etc sounds a bit ungrammatical. "Method added in" or something like that would be better

@julienrbrt
Copy link
Member Author

My bad English strikes again haha.
I'll update 👍

@julienrbrt julienrbrt changed the title feat(cosmos_proto): add since in ServiceOptions feat(cosmos_proto): add annotation to denote version Apr 18, 2024
@julienrbrt julienrbrt merged commit 0748a2a into main Apr 18, 2024
2 of 3 checks passed
@julienrbrt julienrbrt deleted the julien/since branch April 18, 2024 10:14
@julienrbrt
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants