Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmos-sdk-proto: 2021 edition upgrade; include_str! docs #148

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

tony-iqlusion
Copy link
Member

  • Changes edition attribute to 2021 in Cargo.toml
  • Adds a rust-version attribute set to 1.56
  • Uses the new include_str! feature to import README.md as the toplevel rustdoc documentation for the crate

- Changes `edition` attribute to 2021 in Cargo.toml
- Adds a `rust-version` attribute set to 1.56
- Uses the new `include_str!` feature to import README.md as the
  toplevel rustdoc documentation for the crate
@tony-iqlusion
Copy link
Member Author

Here's a before and after on the rustdoc

Before

Screen Shot 2021-10-28 at 1 24 28 PM

After

Screen Shot 2021-10-28 at 1 24 00 PM

Copy link

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tony-iqlusion tony-iqlusion merged commit a505f1f into main Oct 28, 2021
@tony-iqlusion tony-iqlusion deleted the cosmos-sdk-proto/2021-edition-upgrade branch October 28, 2021 19:54
categories = ["cryptography", "cryptography::cryptocurrencies", "database"]
keywords = ["blockchain", "cosmos", "tendermint", "proto"]
keywords = ["blockchain", "cosmos", "tendermint", "proto"]
edition = "2018"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, now I notice I didn't actually bump this, just moved it 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and bumped it in #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants