Bump cosmos-sdk rev to v0.40.0-rc6 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkilpatr
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
I notice the 'tendermint' files are not currently being used in the repo should we bother to check in the rust files in that case? We are depending on tendermint-proto for those definitions.
Otherwise good and the extra generated files are not offensive, just not needed.
tony-iqlusion
commented
Jan 4, 2021
tony-iqlusion
force-pushed
the
tony-iqlusion/bump-cosmos-sdk-go
branch
from
1b7d5a8
to
fe5a2f7
Compare
|
Looks like cosmos-sdk v0.40.0-rc6 is imminent: cosmos/cosmos-sdk#8249 |
Release notes: cosmos/cosmos-sdk#8249
tony-iqlusion
force-pushed
the
tony-iqlusion/bump-cosmos-sdk-go
branch
from
fe5a2f7
to
d3d729e
Compare
tony-iqlusion
changed the title
|
Went ahead and bumped this PR. There were no changes to the generated protos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the commit hash from this upstream PR which fixes the proto definitions so they compile again:
cosmos/cosmos-sdk#8236