Add staking functions to cosmos-sdk #82
Conversation
|
@tony-iqlusion , @jkilpatr : this pull request adds three staking functions to the cosmos-sdk by extending to existing protobuf methods. Hopefully others will find this useful as well, please take a look. |
| pub validator_address: AccountId, | ||
|
|
||
| /// Amount to send | ||
| pub amount: Option<Coin>, |
There was a problem hiding this comment.
I'm curious... when would this ever be None?
There was a problem hiding this comment.
proto::cosmos::staking::v1beta1::MsgDelegate's amount can be None, so I'm mirroring that here.
There was a problem hiding this comment.
The Rust code generated from the protos has no way to express non-optional fields for messages, so that's not a great thing to go off of.
Looking at the raw Protobuf definition, it's:
message MsgDelegate {
option (gogoproto.equal) = false;
option (gogoproto.goproto_getters) = false;
string delegator_address = 1 [(gogoproto.moretags) = "yaml:\"delegator_address\""];
string validator_address = 2 [(gogoproto.moretags) = "yaml:\"validator_address\""];
cosmos.base.v1beta1.Coin amount = 3 [(gogoproto.nullable) = false];
}It's annotated as non-nullable (using a custom gogoproto directive which the Rust proto parser doesn't understand), so this should be changed to pub amount: Coin and messages missing this field should be rejected.
|
@kimonp this just needs a rustfmt to be mergeable, but also there is one open question it'd be good to get an answer to |
|
Going to merge this. I'll correct the rustfmt issue locally (I'm opening another PR anyway) |
As noted on #82, the `amount` field of `MsgDelegate` is annotated as non-nullable in the upstream cosmos-sdk: https://github.com/cosmos/cosmos-sdk/blob/9fd866e3820b3510010ae172b682d71594cd8c14/proto/cosmos/staking/v1beta1/tx.proto#L89 ```proto message MsgDelegate { option (gogoproto.equal) = false; option (gogoproto.goproto_getters) = false; string delegator_address = 1 [(gogoproto.moretags) = "yaml:\"delegator_address\""]; string validator_address = 2 [(gogoproto.moretags) = "yaml:\"validator_address\""]; cosmos.base.v1beta1.Coin amount = 3 [(gogoproto.nullable) = false]; } ``` This commit changes the `amount` field of the domain type from `Option<Coin>` to `Coin` to reflect that.
As noted on #82, the `amount` field of `MsgDelegate` is annotated as non-nullable in the upstream cosmos-sdk: https://github.com/cosmos/cosmos-sdk/blob/9fd866e3820b3510010ae172b682d71594cd8c14/proto/cosmos/staking/v1beta1/tx.proto#L89 ```proto message MsgDelegate { option (gogoproto.equal) = false; option (gogoproto.goproto_getters) = false; string delegator_address = 1 [(gogoproto.moretags) = "yaml:\"delegator_address\""]; string validator_address = 2 [(gogoproto.moretags) = "yaml:\"validator_address\""]; cosmos.base.v1beta1.Coin amount = 3 [(gogoproto.nullable) = false]; } ``` This commit changes the `amount` field of the domain type from `Option<Coin>` to `Coin` to reflect that.
As noted on #82, the `amount` field of `MsgDelegate` is annotated as non-nullable in the upstream cosmos-sdk: https://github.com/cosmos/cosmos-sdk/blob/9fd866e3820b3510010ae172b682d71594cd8c14/proto/cosmos/staking/v1beta1/tx.proto#L89 ```proto message MsgDelegate { option (gogoproto.equal) = false; option (gogoproto.goproto_getters) = false; string delegator_address = 1 [(gogoproto.moretags) = "yaml:\"delegator_address\""]; string validator_address = 2 [(gogoproto.moretags) = "yaml:\"validator_address\""]; cosmos.base.v1beta1.Coin amount = 3 [(gogoproto.nullable) = false]; } ``` This commit changes the `amount` field of the domain type from `Option<Coin>` to `Coin` to reflect that.
Add staking functions to the cosmos-sdk by extending to existing protobuf methods: