Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic cosmwasm support #96

Merged
merged 7 commits into from
Jul 18, 2021

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Jul 1, 2021

While using the library in conjunction with cosmwasm-based cosmos validators, I found myself writing bunch of code that I figured could instead be contributed back to the community.

This pull request introduces basic support for wasmd. It includes compilation of the protobuf files and conversion of Msg types into something that can be more easily put into Tx Body.

I realise most people would not need it, so I've left it feature-locked behind cosmwasm feature flag.

@tony-iqlusion
Copy link
Member

Thanks! This is definitely interesting.

I'm on vacation and don't have time to review it right now, but perhaps @jkilpatr could take a look in the meantime

@zmanian
Copy link
Member

zmanian commented Jul 4, 2021

This looks good to me.

I don't really know what the answer should be for tracking compatibility with multiple upstream versions should be.

wasmd and the cosmos SDK being versioned independently.

Copy link
Member

@tony-iqlusion tony-iqlusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tony-iqlusion tony-iqlusion merged commit 4299b75 into cosmos:main Jul 18, 2021
This was referenced Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants