Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: script to copy across updated files from main_repo #18

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

samricotta
Copy link
Contributor

@samricotta samricotta commented Sep 6, 2023

The following issue tracks the issue to ensure docs are all up to date and aligning with the main sdk repo part of the revamp epic

cosmos/cosmos-sdk#17642

@samricotta samricotta marked this pull request as ready for review September 6, 2023 15:44
@samricotta samricotta changed the title feat: script to copy across updated files from main_repo feat: script to copy across updated files from main_repo Sep 6, 2023
@samricotta samricotta added the documentation Improvements or additions to documentation label Sep 7, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uACK

Comment on lines +5 to +6
schedule:
- cron: '0 0,12 * * *'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schedule:
- cron: '0 0,12 * * *'
schedule:
- cron: '0 0,12 * * *'
workflow_dispatch

for manual pushes

schedule:
- cron: '0 0 * * *'

workflow_dispatch:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tac0turtle question, i realise I need to change the indent but is it not fine to have the workflow_dispatch: above or should it remain below

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think it matters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay ill change, i need to also add in 0.50 docs into this PR (or put it into another) as npm will not run with the 0.50 as an addition in the versions file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets merge then do it separately. Also when we add new versions will we need to copy it over each time?

@tac0turtle tac0turtle merged commit a4b9119 into main Sep 7, 2023
1 check passed
@tac0turtle tac0turtle deleted the copy-md-v2 branch September 7, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants