Skip to content

Commit

Permalink
allow generation of gentxs with empty memo field
Browse files Browse the repository at this point in the history
Let gentx generation continue when gaiad is unable to retrieve
machine's external IP and print a warning message.

Closes: #3424
  • Loading branch information
Alessio Treglia committed Feb 2, 2019
1 parent 45d59b0 commit 07b1571
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ IMPROVEMENTS
* [\#3418](https://github.com/cosmos/cosmos-sdk/issues/3418) Add vesting account
genesis validation checks to `GaiaValidateGenesisState`.
* [\#3420](https://github.com/cosmos/cosmos-sdk/issues/3420) Added maximum length to governance proposal descriptions and titles
* [\#3424](https://github.com/cosmos/cosmos-sdk/issues/3424) Allow generation of gentxs with empty memo field.

* SDK
* \#3435 Test that store implementations do not allow nil values
Expand Down
4 changes: 3 additions & 1 deletion cmd/gaia/init/gentx.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,11 @@ following delegation and commission default parameters:
if err != nil {
return err
}

ip, err := server.ExternalIP()
if err != nil {
return err
fmt.Fprintf(os.Stderr, "couldn't retrieve an external IP, "+
"consequently the tx's memo field will be unset: %s", err)
}

genDoc, err := LoadGenesisDoc(cdc, config.GenesisFile())
Expand Down

0 comments on commit 07b1571

Please sign in to comment.