fix(server/v2/cometbft): fix slice appending (#21142)

cosmos · Aug 1, 2024 · 49179eb · 49179eb
1 parent aee9803
commit 49179eb
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/server/v2/cometbft/abci.go b/server/v2/cometbft/abci.go
@@ -315,15 +315,16 @@ func (c *Consensus[T]) PrepareProposal(
 	}
 
 	decodedTxs := make([]T, len(req.Txs))
-	for _, tx := range req.Txs {
+	for i, tx := range req.Txs {
 		decTx, err := c.txCodec.Decode(tx)
 		if err != nil {
 			// TODO: vote extension meta data as a custom type to avoid possibly accepting invalid txs
 			// continue even if tx decoding fails
 			c.logger.Error("failed to decode tx", "err", err)
 			continue
 		}
-		decodedTxs = append(decodedTxs, decTx)
+
+		decodedTxs[i] = decTx
 	}
 
 	ciCtx := contextWithCometInfo(ctx, comet.Info{