feedback

cosmos · Mar 5, 2024 · 4dbd031 · 4dbd031
1 parent 28f7b8e
commit 4dbd031
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/x/tx/CHANGELOG.md b/x/tx/CHANGELOG.md
@@ -113,18 +113,18 @@ Ref: https://keepachangelog.com/en/1.0.0/
 ### Improvements
 
 * [#15871](https://github.com/cosmos/cosmos-sdk/pull/15871)
-  * `HandlerMap` now has a `DefaultMode()` getter method
-  * Textual types use `signing.ProtoFileResolver` instead of `protoregistry.Files`
+ * `HandlerMap` now has a `DefaultMode()` getter method
+ * Textual types use `signing.ProtoFileResolver` instead of `protoregistry.Files`
 
 ## v0.6.0
 
 ### API Breaking
 
 * [#15709](https://github.com/cosmos/cosmos-sdk/pull/15709):
-  * `GetSignersContext` has been renamed to `signing.Context`
-  * `GetSigners` now returns `[][]byte` instead of `[]string`
-  * `GetSignersOptions` has been renamed to `signing.Options` and requires `address.Codec`s for account and validator addresses
-  * `GetSignersOptions.ProtoFiles` has been renamed to `signing.Options.FileResolver`
+ * `GetSignersContext` has been renamed to `signing.Context`
+ * `GetSigners` now returns `[][]byte` instead of `[]string`
+ * `GetSignersOptions` has been renamed to `signing.Options` and requires `address.Codec`s for account and validator addresses
+ * `GetSignersOptions.ProtoFiles` has been renamed to `signing.Options.FileResolver`
 
 ### Bug Fixes
 

diff --git a/x/tx/signing/aminojson/aminojson.go b/x/tx/signing/aminojson/aminojson.go
@@ -44,6 +44,7 @@ func NewSignModeHandler(options SignModeHandlerOptions) *SignModeHandler {
  h.encoder = NewEncoder(EncoderOptions{
  FileResolver: options.FileResolver,
  TypeResolver: options.TypeResolver,
+ EnumAsString: false, // ensure enum as string is disabled
  })
  } else {
  h.encoder = *options.Encoder

diff --git a/x/tx/signing/aminojson/json_marshal.go b/x/tx/signing/aminojson/json_marshal.go
@@ -29,6 +29,7 @@ type EncoderOptions struct {
  // DoNotSortFields when set turns off sorting of field names.
  DoNotSortFields bool
  // EnumAsString when set will encode enums as strings instead of integers.
+ // Caution: Enabling this option produce different sign bytes.
  EnumAsString bool
  // TypeResolver is used to resolve protobuf message types by TypeURL when marshaling any packed messages.
  TypeResolver signing.TypeResolver