Skip to content

Commit

Permalink
Remove --select in block command
Browse files Browse the repository at this point in the history
Closes #1968.
  • Loading branch information
mslipper committed Aug 21, 2018
1 parent 204762b commit 5456e54
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 1 addition & 0 deletions PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ IMPROVEMENTS
* [x/stake] \#2000 Added tests for new staking endpoints

* Gaia CLI (`gaiacli`)
* [cli] #2060 removed `--select` from `block` command

* Gaia
* [x/stake] [#2023](https://github.com/cosmos/cosmos-sdk/pull/2023) Terminate iteration loop in `UpdateBondedValidators` and `UpdateBondedValidatorsFull` when the first revoked validator is encountered and perform a sanity check.
Expand Down
6 changes: 0 additions & 6 deletions client/rpc/block.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ import (
"github.com/spf13/cobra"
)

const (
flagSelect = "select"
)

//BlockCommand returns the verified block data for a given heights
func BlockCommand() *cobra.Command {
cmd := &cobra.Command{
Expand All @@ -27,7 +23,6 @@ func BlockCommand() *cobra.Command {
cmd.Flags().StringP(client.FlagNode, "n", "tcp://localhost:26657", "Node to connect to")
// TODO: change this to false when we can
cmd.Flags().Bool(client.FlagTrustNode, true, "Don't verify proofs for responses")
cmd.Flags().StringSlice(flagSelect, []string{"header", "tx"}, "Fields to return (header|txs|results)")
return cmd
}

Expand All @@ -38,7 +33,6 @@ func getBlock(cliCtx context.CLIContext, height *int64) ([]byte, error) {
return nil, err
}

// TODO: actually honor the --select flag!
// header -> BlockchainInfo
// header, tx -> Block
// results -> BlockResults
Expand Down

0 comments on commit 5456e54

Please sign in to comment.