implement feedback

cosmos · Sep 21, 2022 · 5edef43 · 5edef43
1 parent 4a25009
commit 5edef43
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 10 deletions.
diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml
@@ -20,12 +20,11 @@ permissions:
 jobs:
   test-e2e:
     runs-on: ubuntu-latest
-    needs: build
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
       - name: e2e tests
         run: |
-          cd tests && make test-e2e
+          make test-e2e
diff --git a/.github/workflows/test-integration.yml b/.github/workflows/test-integration.yml
@@ -20,12 +20,11 @@ permissions:
 jobs:
   test-integration:
     runs-on: ubuntu-latest
-    needs: build
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
           go-version: 1.18
       - name: integration tests
         run: |
-          cd tests && make test-integration
+          make test-integration
diff --git a/.github/workflows/test-legacy.yml b/.github/workflows/test-legacy.yml
@@ -76,7 +76,7 @@ jobs:
           path: ./${{ matrix.part }}profile.out
 
   sims-notify-success:
-    needs: [tests]
+    needs: tests
     runs-on: ubuntu-latest
     if: ${{ success() }}
     steps:
@@ -102,7 +102,7 @@ jobs:
           SLACK_FOOTER: ""
 
   sims-notify-failure:
-    needs: [tests]
+    needs: tests
     runs-on: ubuntu-latest
     if: ${{ failure() }}
     steps:

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -232,7 +232,6 @@ jobs:
 
   test-sim-nondeterminism:
     runs-on: buildjet-4vcpu-ubuntu-2004
-    needs: [build]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3

diff --git a/Makefile b/Makefile
@@ -210,7 +210,11 @@ build-docs:
 ###############################################################################
 
 test: test-unit
-test-all: test-unit test-ledger-mock test-race test-cover
+test-e2e:
+	make -C tests test-e2e
+test-integration:
+	make -C tests test-integration
+test-all: test-unit test-e2e test-integration test-ledger-mock test-race test-cover
 
 TEST_PACKAGES=./...
 TEST_TARGETS := test-unit test-unit-amino test-unit-proto test-ledger-mock test-race test-ledger test-race

diff --git a/tests/Makefile b/tests/Makefile
@@ -1,5 +1,3 @@
-test: test-integration test-e2e 
-
 test-integration:
 	go test ./integration/... -timeout 30m