remove txs from mempool when antehandler fails in recheck

cosmos · Apr 22, 2024 · 605b996 · 605b996
1 parent e59ca15
commit 605b996
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/baseapp/baseapp.go b/baseapp/baseapp.go
@@ -911,6 +911,12 @@ func (app *BaseApp) runTx(mode execMode, txBytes []byte) (gInfo sdk.GasInfo, res
 		gasWanted = ctx.GasMeter().Limit()
 
 		if err != nil {
+			if mode == execModeReCheck {
+				// if the ante handler fails on recheck, we want to remove the tx from the mempool
+				if err := app.mempool.Remove(tx); err != nil {
+					return gInfo, nil, anteEvents, errors.Join(err, err)
+				}
+			}
 			return gInfo, nil, nil, err
 		}