Skip to content

Commit

Permalink
fix: attempt at fixing flaky e2e tests (#13401)
Browse files Browse the repository at this point in the history
* fix: attempt at fixing flaky e2e tests

* `make format`

* add links
  • Loading branch information
julienrbrt authored Sep 27, 2022
1 parent 6f337b4 commit 684ee62
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/build-skip.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: Build SimApp
# This workflow allows to skip the build step if the PR does not contain any changes to the code
# See https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks
on:
pull_request:
paths-ignore:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-e2e-skip.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: Tests E2E
# This workflow allows to skip the e2e step if the PR does not contain any changes to the code
# See https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks
on:
pull_request:
paths-ignore:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-integration-skip.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: Tests Integration
# This workflow allows to skip the integration step if the PR does not contain any changes to the code
# See https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks
on:
pull_request:
paths-ignore:
Expand Down
1 change: 0 additions & 1 deletion baseapp/baseapp.go
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,6 @@ func (app *BaseApp) MountStore(key storetypes.StoreKey, typ storetypes.StoreType
// LoadLatestVersion loads the latest application version. It will panic if
// called more than once on a running BaseApp.
func (app *BaseApp) LoadLatestVersion() error {

err := app.storeLoader(app.cms)
if err != nil {
return fmt.Errorf("failed to load latest version: %w", err)
Expand Down
2 changes: 2 additions & 0 deletions tests/e2e/group/tx.go
Original file line number Diff line number Diff line change
Expand Up @@ -2151,6 +2151,8 @@ func (s *IntegrationTestSuite) TestTxLeaveGroup() {
),
)
s.Require().NoError(err, out.String())
s.Require().NoError(s.network.WaitForNextBlock())

var txResp sdk.TxResponse
s.Require().NoError(val.ClientCtx.Codec.UnmarshalJSON(out.Bytes(), &txResp), out.String())
txResp, err = clitestutil.GetTxResponse(s.network, val.ClientCtx, txResp.TxHash)
Expand Down
1 change: 1 addition & 0 deletions x/auth/client/testutil/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,7 @@ func (s *IntegrationTestSuite) TestSignWithMultiSignersAminoJSON() {
)
require.NoError(err)
require.NoError(s.network.WaitForNextBlock())
require.NoError(s.network.WaitForNextBlock())

var txRes sdk.TxResponse
require.NoError(val0.ClientCtx.Codec.UnmarshalJSON(res.Bytes(), &txRes))
Expand Down

0 comments on commit 684ee62

Please sign in to comment.