Merge PR #2152: Make CI not update the lock file

* CI: Make CI not update the lock file

We want CI to be running the lock in the repo, not generating a new one.
Linting now ensures that the lock file is up to date.

* Switch to Chris' comment

* Update pending to indicate this new command

Makefile

@@ -106,6 +106,11 @@ get_dev_tools:
 	cd tools && $(MAKE) get_dev_tools
 
 get_vendor_deps:
+	@echo "--> Generating vendor directory via dep ensure"
+	@rm -rf .vendor-new
+	@dep ensure -v -vendor-only
+
+update_vendor_deps:
 	@echo "--> Running dep ensure"
 	@rm -rf .vendor-new
 	@dep ensure -v

PENDING.md

@@ -12,6 +12,7 @@ BREAKING CHANGES
     * [cli] \#1983 you can now pass --pubkey or --address to gaiacli keys show to return a plaintext representation of the key's address or public key for use with other commands
     * [cli] \#2061 changed proposalID in governance REST endpoints to proposal-id
     * [cli] \#2014 `gaiacli advanced` no longer exists - to access `ibc`, `rest-server`, and `validator-set` commands use `gaiacli ibc`, `gaiacli rest-server`, and `gaiacli tendermint`, respectively
+    * [makefile] `get_vendor_deps` no longer updates lock file it just updates vendor directory. Use `update_vendor_deps` to update the lock file. [#2152](https://github.com/cosmos/cosmos-sdk/pull/2152)
 
 * Gaia
     * Make the transient store key use a distinct store key. [#2013](https://github.com/cosmos/cosmos-sdk/pull/2013)