fix(simapp): do not repeat errors (backport #16865) (#16872)

Co-authored-by: Julien Robert <julien@rbrt.fr>
cosmos · Jul 7, 2023 · e141d8e · e141d8e
1 parent d6780c1
commit e141d8e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/simapp/simd/cmd/root.go b/simapp/simd/cmd/root.go
@@ -65,8 +65,9 @@ func NewRootCmd() *cobra.Command {
  WithViper("") // In simapp, we don't use any prefix for env variables.
 
  rootCmd := &cobra.Command{
- Use: "simd",
- Short: "simulation app",
+ Use: "simd",
+ Short: "simulation app",
+ SilenceErrors: true,
  PersistentPreRunE: func(cmd *cobra.Command, _ []string) error {
  // set the default command outputs
  cmd.SetOut(cmd.OutOrStdout())

diff --git a/simapp/simd/cmd/root_v2.go b/simapp/simd/cmd/root_v2.go
@@ -76,8 +76,9 @@ func NewRootCmd() *cobra.Command {
  WithViper("") // In simapp, we don't use any prefix for env variables.
 
  rootCmd := &cobra.Command{
- Use: "simd",
- Short: "simulation app",
+ Use: "simd",
+ Short: "simulation app",
+ SilenceErrors: true,
  PersistentPreRunE: func(cmd *cobra.Command, _ []string) error {
  // set the default command outputs
  cmd.SetOut(cmd.OutOrStdout())

diff --git a/simapp/simd/main.go b/simapp/simd/main.go
@@ -1,9 +1,9 @@
 package main
 
 import (
+ "fmt"
  "os"
 
- "cosmossdk.io/log"
  "cosmossdk.io/simapp"
  "cosmossdk.io/simapp/simd/cmd"
 
@@ -13,7 +13,7 @@ import (
 func main() {
  rootCmd := cmd.NewRootCmd()
  if err := svrcmd.Execute(rootCmd, "", simapp.DefaultNodeHome); err != nil {
- log.NewLogger(rootCmd.OutOrStderr()).Error("failure when running app", "err", err)
+ fmt.Fprintln(rootCmd.OutOrStderr(), err)
  os.Exit(1)
  }
 }