fix(sims): check before sending RotateConsPubKey (#20659)

cosmos · Jun 13, 2024 · ec96e79 · ec96e79
1 parent 748a939
commit ec96e79
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/x/staking/simulation/operations.go b/x/staking/simulation/operations.go
@@ -832,6 +832,17 @@ func SimulateMsgRotateConsPubKey(txGen client.TxConfig, ak types.AccountKeeper,
 			return simtypes.NoOpMsg(types.ModuleName, msgType, "unable to build msg"), nil, err
 		}
 
+		// check if there's another key rotation for this same key in the same block
+		allRotations, err := k.GetBlockConsPubKeyRotationHistory(ctx)
+		if err != nil {
+			return simtypes.NoOpMsg(types.ModuleName, msgType, "cannot get block cons key rotation history"), nil, err
+		}
+		for _, r := range allRotations {
+			if r.NewConsPubkey.Compare(msg.NewPubkey) == 0 {
+				return simtypes.NoOpMsg(types.ModuleName, msgType, "cons key already used in this block"), nil, nil
+			}
+		}
+
 		txCtx := simulation.OperationInput{
 			R:               r,
 			App:             app,