AllowedMsgAllowance does not subtract fees from spend_limit
#10563
Comments
This was referenced Nov 17, 2021
mergify bot
pushed a commit
that referenced
this issue
Jan 5, 2022
## Description Closes: #10563 By the fix, AllowedMsgAllowance updates its allowance after the change in `Accept()`. To catch the corresponding issue, the fix also adds new unit tests. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of Bug
AllowedMsgAllowance does not subtract the fees from
spend_limit. The granter pays the fee correctly, and the module checksspend_limitso if the requested amount of fee is greater than the limit, it rejects the transaction. However, after the transaction,spend_limit, which should have been subtracted by the amount of fee, is intact.Version
v0.44.3
Steps to Reproduce
$ simd tx feegrant grant $granter $grantee --spend-limit $limit --allowed-messages "/cosmos.bank.v1beta1.MsgSend"
$ simd query feegrant grants $grantee // remember spend_limit
$ simd tx bank send $grantee $other $sendamount --fee-account $granter --fees $fee
$ simd query feegrant grants $grantee // spend_limit has not decreased
For Admin Use
The text was updated successfully, but these errors were encountered: